Date: Tue, 18 Jan 2005 12:43:44 +0100 From: Jeremie Le Hen <jeremie@le-hen.org> To: Florent Thoumie <flz@xbsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: WITHOUT_X11 knob for mplayer Message-ID: <20050118114344.GR36629@obiwan.tataz.chchile.org> In-Reply-To: <20050118103850.GQ36629@obiwan.tataz.chchile.org> References: <20050118085557.GP36629@obiwan.tataz.chchile.org> <41ECD481.4020308@xbsd.org> <20050118103850.GQ36629@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Ok, I'm going to update my patch today. Thanks for the tip. Well I updated the patch and then tried to rebuild mplayer on my no-X11 computer, unfortunately xorg-libraries has been built. I had a look in the porter's handbook. Here are the drawbacks I found about using USE_IMAKE knob: %%% Define USE_XLIB=yes if your port requires the X Window System to be installed (it is implied by USE_IMAKE). USE_IMAKE The port uses imake. Implies USE_X_PREFIX. %%% Obviously, this would make my patch completely useless :-). Whereas it can be interpreted as an inconsistency in the mplayer build system (usage of imake(1) even if not linked with X11 libs), my opinion is that this is a ports system weakness for this particular situation. Nevertheless I'm convinced there are good reasons to have the USE_IMAKE knob implying the USE_XLIB one. I would like to circomvent the use of USE_IMAKE here. Florent stated that the imake version depends on X_WINDOWS_SYSTEM but my BUILD_DEPENDS is only used when the WITHOUT_X11 knob is on. Thus I think we could use an arbitrary version of imake (say imake-6). This won't be very fair for those still running XFree86 as X_WINDOWS_SYSTEM and building mplayer WITHOUT_X11, but there are obviously a very few. Do you all agree with me ? (Thus my patch will stay as-is, unless there is a good solution to solve this problem.) Regards, -- Jeremie Le Hen jeremie@le-hen.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050118114344.GR36629>