Date: Sat, 26 Feb 2005 04:34:05 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Jose M Rodriguez <josemi@freebsd.jazztel.es> Cc: FreeBSD GNOME Users <gnome@FreeBSD.org> Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package script Message-ID: <1109410446.61886.27.camel@shumai.marcuscom.com> In-Reply-To: <200502261027.00849.josemi@freebsd.jazztel.es> References: <200502250756.j1P7uEn0023933@freefall.freebsd.org> <200502250922.17098.josemi@freebsd.jazztel.es> <1109406753.61886.24.camel@shumai.marcuscom.com> <200502261027.00849.josemi@freebsd.jazztel.es>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-hNrf6rN7UZpujfegtOo4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Sat, 2005-02-26 at 10:27 +0100, Jose M Rodriguez wrote:
> El S=E1bado, 26 de Febrero de 2005 09:32, Joe Marcus Clarke escribi=F3:
> > On Fri, 2005-02-25 at 09:22 +0100, Jose M Rodriguez wrote:
> > > El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribi=F3=
:
> > > > Synopsis: [PATCH] www/firefox: new mozilla.sh and package script
> > > > <snip/>
> > >
> > > Please, consider the cleanhome moz_pis for firefox. This makes
> > > firefox upgrades don't be hurt by local profile.
> >
> > This could be useful. However, I have some concerns, and the
> > comments in the script didn't help. This removes the pluginreg.dat
> > every time Firefox is started. Will that have any negative effects?=20
> > What about performance? Couldn't this be wrapped about the -ot
> > comparison as well? Also, you have a typo. The file is XUL.mfasl,
> > not XUL.mfast.
> >
>=20
> Firts, I think we have time until 1.1/1.5 landing, so this can be worked=20
> better.
>=20
> - I think having moz_pis processing in the Makefile is a good thing,=20
> with or without this or that script. The mozilla.sh script seems to be=20
> a common denominator and moz_pis the way to get special things.
>=20
> - The actual script in latest post is:
> #!/bin/sh
> #
>=20
> # S50cleanhome
> # a script to polite ${HOME}/${MOZ_PIS_USER_DIR}
>=20
> # We run in our own subshell
>=20
> # First, verify protocol
> [ "$1" !=3D "start" ] && exit 1
> [ -z "${MOZ_PIS_API}" -o ${MOZ_PIS_API} -ne 2 ] && exit 1
> [ -z "${MOZ_PIS_MOZBINDIR}" -o ! -d "${MOZ_PIS_MOZBINDIR}" ] && exit 1
> [ -z "${HOME}" -o ! -d "${HOME}" ] && exit 1
> [ -z "${MOZ_PIS_USER_DIR}" -o ! -d "${HOME}/${MOZ_PIS_USER_DIR}" ] &&=20
> exit 1
>=20
> # Try to polite ${HOME}/${MOZ_PIS_USER_DIR}
>=20
> # This must be really needed?
> # rm -f "${$HOME}/${MOZ_PIS_USER_DIR}/pluginreg.dat"
>=20
> # Try to polite profile dirs
> if [ -f "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" ]; then
> sed -e '/Path=3D/! d' -e "s,Path=3D,${HOME}/${MOZ_PIS_USER_DIR}/," \
> "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" \
> | while read dir
> do
> [ ! -d "${dir}" ] && continue
> # at last, debian do this, we do for new builds
> # rm -f "${dir}/XUL.mfast"
> # make reclaculate compreg.dat, xpti.dat for new builds
> [ "${dir}/compreg.dat" -ot=20
> "${MOZ_PIS_MOZBINDIR}/components.ini" ] &&
> rm -f "${dir}/compatibility.ini" "${dir}/XUL.mfast"
> done
> fi
>=20
> I try to import debian work, but taking mozilla guidelines.
>=20
> I don't remove pluginreg.dat. But this is done in debian and maybe=20
> needed.
I saw this after a more careful reading. In any event, I committed the
script as it was (with the mfasl bug fix).
>=20
> As I comment in the pkg scripts, I'll prefer have just one .keepme file=20
> in ${PLUGINDIR} and make all ports, even plugins 'touch this'.
I'll have to see how you do this. In general, touching one file across
multiple ports is not a good idea.
>=20
> In any case, If I enable pluginreg.dat removal, must be after a safe age=20
> test.
I tested this here, and it seemed to work without removing it. However,
if you find removing it does more good than harm, we can consider adding
it at a later time.
Joe
--=20
Joe Marcus Clarke
FreeBSD GNOME Team :: gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
--=-hNrf6rN7UZpujfegtOo4
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iD8DBQBCIEKNb2iPiv4Uz4cRApPcAKCF+GSTNW8+B28UpJyQMeZM8uyFawCfVQ5B
NsClC1cT3xYNhWXlpUnELRk=
=98bp
-----END PGP SIGNATURE-----
--=-hNrf6rN7UZpujfegtOo4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1109410446.61886.27.camel>