Date: Thu, 17 Mar 2005 14:46:13 +0100 From: Michal Mertl <mime@traveller.cz> To: Anton Berezin <tobez@freebsd.org> Cc: freebsd-audit@freebsd.org Subject: Re: [PATCH] review requested, add sha256 to mtree + small fixes Message-ID: <1111067173.670.14.camel@genius2.i.cz> In-Reply-To: <20050317110538.GA61247@heechee.tobez.org> References: <20050317110538.GA61247@heechee.tobez.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Anton Berezin wrote: > Since we now have sha256 in libmd, I think it is time to add it to > mtree(1). I think all longer sha variants should be added at the same time. There are implementations of SHA-384 a SHA-512 already available in src/sys/crypto/sha2. ISTR someone is working at the moment on the cleanup of crypto algorithms' implementations in the tree so that there's only one copy of each or at most two (openssl and small-util/kernel one). Colin's sha256 implementation is IMHO a step in the wrong direction. He admitted he hadn't known about the other implementation in the tree, otherwise he probably wouldn't have written the new one in libmd. I haven't looked at your patch, sorry. Just my 2 cents. Michal Mertl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1111067173.670.14.camel>