Date: Fri, 01 Apr 2005 16:00:30 -0700 From: Phil Oleson <oz@nixil.net> To: "Matthew N. Dodd" <mdodd@FreeBSD.ORG> Cc: freebsd-current@FreeBSD.ORG Subject: Re: request: libedit sync Message-ID: <424DD28E.9040000@nixil.net> In-Reply-To: <20050331233821.Q328@sasami.jurai.net> References: <4244AC9C.7010803@nixil.net> <20050326030927.GA86483@xor.obsecurity.org> <424CAF89.60209@nixil.net> <20050331233821.Q328@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew N. Dodd wrote:
> On Thu, 31 Mar 2005, Phil Oleson wrote:
>
>> btw, I was a bit unsure if I should increment 'SHLIB_MAJOR' to 5.
>> There were some small changes (exposed some tok_xx functions) but it
>> also removed el_data_get() & el_data_set(). blah..
>
>
> el_data_{get,set}() were local changes. It would be really nice if
> they stayed.
>
hmm.. that was a detail I overlooked. I have not been able to track
down where these
functions are used. Can you assist with that? These calls could be
changed to use
el_get(el, EL_CLIENTDATA, data) && el_set(el, EL_CLIENTDATA, data), and
we could
eliminate these non-portable local changes.
Phil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?424DD28E.9040000>