Date: Fri, 08 Jul 2005 16:17:54 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: usb@FreeBSD.ORG Subject: Re: Proposed patch to ulpt.c Message-ID: <20050708.161754.79267773.imp@bsdimp.com> In-Reply-To: <20050708.161257.58435372.imp@bsdimp.com> References: <20050708.161257.58435372.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----Next_Part(Fri_Jul__8_16:17:54_2005_414)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Ooops. In my last message, there's an extra chunk in the patch, left
over from debugging. Please try this one instead.
Warner
----Next_Part(Fri_Jul__8_16:17:54_2005_414)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="ulpt.diff"
Index: ulpt.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/ulpt.c,v
retrieving revision 1.66
diff -u -r1.66 ulpt.c
--- ulpt.c 6 Jan 2005 01:43:28 -0000 1.66
+++ ulpt.c 8 Jul 2005 22:12:33 -0000
@@ -543,28 +544,6 @@
}
}
- for (spin = 0; (ulpt_status(sc) & LPS_SELECT) == 0; spin += STEP) {
- DPRINTF(("ulpt_open: waiting a while\n"));
- if (spin >= TIMEOUT) {
- error = EBUSY;
- sc->sc_state = 0;
- goto done;
- }
-
- /* wait 1/4 second, give up if we get a signal */
- error = tsleep(sc, LPTPRI | PCATCH, "ulptop", STEP);
- if (error != EWOULDBLOCK) {
- sc->sc_state = 0;
- goto done;
- }
-
- if (sc->sc_dying) {
- error = ENXIO;
- sc->sc_state = 0;
- goto done;
- }
- }
-
err = usbd_open_pipe(sc->sc_iface, sc->sc_out, 0, &sc->sc_out_pipe);
if (err) {
error = EIO;
----Next_Part(Fri_Jul__8_16:17:54_2005_414)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050708.161754.79267773.imp>