Date: Fri, 22 Jul 2005 19:46:35 +0200 From: Florent Thoumie <flz@xbsd.org> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: freebsd-ports@FreeBSD.org, edwin@FreeBSD.org Subject: Re: ngrep and libpcap from ports Message-ID: <1122054396.97024.7.camel@cream.xbsd.org> In-Reply-To: <20050722173215.GR39292@obiwan.tataz.chchile.org> References: <20050722150032.GP39292@obiwan.tataz.chchile.org> <1122050545.97024.2.camel@cream.xbsd.org> <20050722173215.GR39292@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-3oCjyX5KaUE8O5UpcyBR
Content-Type: text/plain; charset=iso8859-15
Content-Transfer-Encoding: quoted-printable
Le Vendredi 22 juillet 2005 =E0 19:32 +0200, Jeremie Le Hen a =E9crit :
> Florent,
>=20
> > > This patch will link against the libpcap from ports if it exists.
> > > I'm not sure this is the correct way to write this, feel free to chan=
ge
> > > it's needed.
> >=20
> > I wouldn't fix it that way because it would lead to unexpected=20
> > behavior.
> >=20
> > I'd use base pcap includes unless WITH_PORTS_PCAP is defined=20
> > (which add pcap to LIB_DEPENDS).
>=20
> Thanks for your reply. I'll take it as the way to go it as I'm
> convinced you are far more experienced in ports than I am.
>=20
> Here is the updated patch. Note nevertheless that adding
> --with-pcap-includes=3D${PREFIX}/include
> to CONFIGURE_ARGS is required or ngrep configure script will fail
> miserably with the message I showed in my previous mail.
>=20
> Regards,
Still won't work for you (or people who have libpcap installed=20
from ports and doesn't have WITH_PORTS_LIBPCAP).
Something like this would be more appropriate :
.if !defined(WITH_PORTS_LIBPCAP)
# Default behavior
CONFIGURE_ARGS+=3D --with-pcap-includes=3D/usr/include
.else
CONFIGURE_ARGS+=3D --with-pcap-includes=3D${PREFIX}/include
LIB_DEPENDS=3D pcap.2:${PORTSDIR}/net/libpcap
.endif
--=20
Florent Thoumie
flz@xbsd.org
--=-3oCjyX5KaUE8O5UpcyBR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQBC4TD7MxEkbVFH3PQRAoVAAJ9eChw/r8pgMGxBKjfgtFsc0N8clQCffOa3
sqz+DHE/GkuLIfMTIqhRdFg=
=zQi3
-----END PGP SIGNATURE-----
--=-3oCjyX5KaUE8O5UpcyBR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1122054396.97024.7.camel>