Date: Sun, 6 Nov 2005 10:30:36 +0900 From: Hye-Shik Chang <perky@freebsd.org> To: Filippo Natali <filippo.natali@gmail.com> Cc: FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>, python@freebsd.org Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports Message-ID: <20051106013036.GA39761@FreeBSD.org> In-Reply-To: <200511032035.40302.filippo.natali@gmail.com> References: <1129366769.0@ulby.hq.netwing.it> <200511021753.27516.filippo.natali@gmail.com> <20051103150643.GA30821@FreeBSD.org> <200511032035.40302.filippo.natali@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 03, 2005 at 08:35:39PM +0100, Filippo Natali wrote: > Alle 16:06, gioved? 3 novembre 2005, Hye-Shik Chang ha scritto: > > Okay. I revised the patch for some flexibility for USE_ZOPE and > > ZOPE_VERSION simliar to PYTHON equivalents. > > > > http://people.freebsd.org/~perky/pythonmk-zope28support-2.diff > > >=20 > There's a little typo in Zope 3.1 selection: >=20 > [snip] > -# Zope specific variables > +# Zope-related variables > .if defined(USE_ZOPE) > +.if ${ZOPE_VERSION} =3D=3D "3.1" > +SZOPEBASEDIR?=3D www/Zope28 > +ZOPE_PORTSDIR=3D ${PORTSDIR}/www/zope28 > +.elif ${ZOPE_VERSION} =3D=3D "2.8" > [snip] >=20 > Except this, it works fine. Thanks for the review and comments! I just committed it in CVS. If you find any problem for that, please let me know. Hye-Shik --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDbVy8DWUsWc/bS6QRAoW4AKCSr5aIL6FVtxKkDXGiouGOavdfYQCgyoCd 78pqD2EjOFYIy9/zhzs34JM= =rExP -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051106013036.GA39761>