Date: Mon, 6 Feb 2006 14:36:29 +0300 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Max Laier <max@love2party.net> Cc: freebsd-net@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, Luigi Rizzo <rizzo@icir.org> Subject: Re: if_bridge.ko requires INET6... Message-ID: <20060206113629.GF59508@comp.chem.msu.su> In-Reply-To: <200602051824.28100.max@love2party.net> References: <20060201005658.A70005@xorpc.icir.org> <200602021437.38385.max@love2party.net> <200602041616.57224.max@love2party.net> <200602051824.28100.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 05, 2006 at 06:24:20PM +0100, Max Laier wrote: > On Saturday 04 February 2006 16:16, Max Laier wrote: > > On Thursday 02 February 2006 14:37, Max Laier wrote: > > > On Thursday 02 February 2006 13:43, Yar Tikhiy wrote: > > > > > This needs to be fixed in pf then. > > > > > > > > Max Laier and I discussed this issue once, and Max had concern > > > > over possible performance degradation that might result from > > > > calling pflog functions through pointers to be set by a separate > > > > pflog module. We can skip touching the pf module in RELENG_6 for > > > > now and leave the issue to after 6.1-RELEASE is out. > > > > > > I have convinced myself that we should really use a function pointer > > > here. I will try to commit a sollution to HEAD over the weekend. If you > > > are MFC'ing the changes *now*, I'd appreciate if you could spare out pf, > > > but I am willing to MFC the changes before 6.1 if testing goes well. > > > > Here it is. I'd appreciate feedback. pflog_packet() uses a lot of complex > > types which makes it necessary to include pfvar.h. This is ugly, but I > > don't know how to work around this. > > FYI, just committed this to the tree. I'm sorry I was a bit too late with my remarks... -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060206113629.GF59508>