Date: Wed, 22 Mar 2006 02:20:15 +0000 From: Ian Dowse <iedowse@iedowse.com> To: Anish Mistry <mistry.7@osu.edu> Cc: freebsd-usb@freebsd.org Subject: Re: [PATCH] Logitech USB Receiver mouse workaround patch Message-ID: <200603220220.aa96629@nowhere.iedowse.com> In-Reply-To: Your message of "Tue, 21 Mar 2006 15:10:10 EST." <200603211510.18064.mistry.7@osu.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200603211510.18064.mistry.7@osu.edu>, Anish Mistry writes: >I've just tested this and it works. It fixes the problem, rather than >hacking around it like the last commit to hid.c. >Ian, can you see that this makes it into 6.1? It's in -current now, thanks. I'll ask to MFC it in a few days - remind me again if you don't see it MFC'd soon. It looked ok based on a quick glance at the HID spec, and it didn't seem to cause any problems with 3 random mice I have here. A subtle difference between our hid.c and NetBSD's is that NetBSD's hid_report_size() doesn't add in the size of the extra report ID byte, so it has to compensate for it later - that explains the 'size += 8' that is in our code but not in NetBSD's. Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603220220.aa96629>