Date: Sun, 18 Jun 2006 10:40:16 +0200 From: Divacky Roman <xdivac02@stud.fit.vutbr.cz> To: Kris Kennaway <kris@obsecurity.org> Cc: current@freebsd.org Subject: Re: HEADS-UP: removed COMPAT_43 from GENERIC (and other configs) Message-ID: <20060618084016.GA44510@stud.fit.vutbr.cz> In-Reply-To: <20060617084626.GA20327@xor.obsecurity.org> References: <3223.1150403817@critter.freebsd.dk> <200606151259.57929.beech@alaskaparadise.com> <20060615212048.GA72318@xor.obsecurity.org> <20060616062841.GA2193@haakonia.hitnet.RWTH-Aachen.DE> <20060616084538.69fki90ri8wk8kcg@netchild.homeip.net> <20060616151931.GA42934@xor.obsecurity.org> <20060617083156.GA84611@stud.fit.vutbr.cz> <20060617084626.GA20327@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 17, 2006 at 04:46:27AM -0400, Kris Kennaway wrote: > On Sat, Jun 17, 2006 at 10:31:56AM +0200, Divacky Roman wrote: > > On Fri, Jun 16, 2006 at 11:19:31AM -0400, Kris Kennaway wrote: > > > On Fri, Jun 16, 2006 at 08:45:38AM +0200, Alexander Leidinger wrote: > > > > Quoting Christian Brueffer <brueffer@FreeBSD.org> (from Fri, 16 Jun > > > > 2006 08:28:41 +0200): > > > > > > > > >On Thu, Jun 15, 2006 at 05:20:49PM -0400, Kris Kennaway wrote: > > > > > > > > >>I did a full build for phk some time ago, I don't remember how many > > > > >>broke but it was enough to make it a significant (but perhaps not > > > > >>difficult) task to fix them. > > > > >> > > > > > > > > > >I think it would be helpful to do another run if possible and put the > > > > >results online somewhere. That could significantly speed up the whole > > > > >issue. > > > > > > > > That would be nice. And toss the list to me and Joel in case you do > > > > it, we will add an entry on the ideas list for this. > > > > > > I don't have time to rerun but here is the list from last time as a > > > starting point: > > > > > > --- > > > On Tue, Jan 10, 2006 at 10:52:38AM +0100, Poul-Henning Kamp wrote: > > > > > > > > Can I get you to look out for this one in the build logs ? > > > > > > > > #warning "Old BSD tty API used, please upgrade." > > > > > > > > Poul-Henning > > > > I am running COMPAT_43*-less kernel and I successfully built at least gtar from > > your list... basically I think that the only affected ports are those with mess > > with serial port etc. ie. where you use ioctl() on some tty device.... > > I doubt the list is accurate... there must have been another issue when you > > tried that > > It's possible I screwed up, but I just did a grep on all the build > logs for the warning message. Are you certain it didn't appear? well.. you can never be sure but my point stands still - COMPAT_43TTY is basically a bunch of tty-related ioctls so I dont see why apps like (gtar which doesnt touch tty at all) should fail.. I can see breakage in things related to modem $something, serial consoles emulators etc. which use tty and might want to change its setting by ioctl. what I am trying to say is - the set of apps which breaks by removing COMPAT_43TTY should be very limited. But on the other hand - what benefit does removing it brings? It saves tens or hundreds of bytes of compiled kernel and thats all. COMPAT_43 removal is great because it removes old code, lowers contention of some mutexes and brings speedup. COMPAT_43TTY removes a bunch of ioctls. We have lived with COMPAT_43 for ages and I think we can live for some more with COMPAT_43TTY. The effort to make livign without COMPAT_43TTY might be better spent elsewhere just my 2 cents roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060618084016.GA44510>