Date: Sat, 4 Nov 2006 14:24:30 -0800 (PST) From: Jeff Roberson <jroberson@chesapeake.net> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-hackers@freebsd.org, xdivac02@stud.fit.vutbr.cz, "Andrey V. Elsukov" <bu7cher@yandex.ru>, joel@freebsd.org Subject: Re: Yet another magic symlinks implementation Message-ID: <20061104124649.M622@10.0.0.1> In-Reply-To: <20061104134448.GM12108@deviant.kiev.zoral.com.ua> References: <454C55BD.000003.22283@webmail11.yandex.ru> <20061104090204.GA38945@stud.fit.vutbr.cz> <454C75B9.000002.09555@mfront8.yandex.ru> <20061104134448.GM12108@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 4 Nov 2006, Kostik Belousov wrote: > On Sat, Nov 04, 2006 at 02:12:57PM +0300, Andrey V. Elsukov wrote: >>> On Sat, Nov 04, 2006 at 11:56:29AM +0300, Andrey V. Elsukov wrote: >>>> I've ported NetBSD magic symlinks implementation to FreeBSD. >>>> The description of magiclinks can been found here: >>>> http://www.daemon-systems.org/man/symlink.7.html >>>> >>>> Patch here: >>>> http://butcher.heavennet.ru/patches/kernel/magiclinks/ >>> >>> thnx for porting this, have you checked locking? netbsd >>> kernel is still under one giant lock so locking might >>> differ. >> >> Sorry, i'm not locking guru.. Code seems simple.. >> Mybe somebody from committers can see into code? >> Konstantin, Jeff, whath you think? > > I don't think that any additional locking is required there. > No additional locking is required. This code really needs some work though. First of all, macros should never operate on variables not passed in as arguments. The SUBSTITUTE macro should be a function. The matching algorithm is not very efficient either. Jeff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061104124649.M622>