Date: Sun, 26 Nov 2006 21:36:29 +0000 From: Florent Thoumie <flz@FreeBSD.org> To: Alexander Botero-Lowry <alexbl@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: rcvar function in rc.subr Message-ID: <456A08DD.2080205@FreeBSD.org> In-Reply-To: <200611262125.kAQLPFHS029942@Laptop.mine.box> References: <1161268403.89897.1.camel@mayday.esat.net> <20061126121907.GC60959@comp.chem.msu.su> <4569A113.5080106@FreeBSD.org> <20061126181422.GA66009@comp.chem.msu.su> <200611262125.kAQLPFHS029942@Laptop.mine.box>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Alexander Botero-Lowry wrote: >> On Sun, Nov 26, 2006 at 02:13:39PM +0000, Florent Thoumie wrote: >>> Yar Tikhiy wrote: >>>> On Thu, Oct 19, 2006 at 03:33:23PM +0100, Florent Thoumie wrote: >>>>> Does anybody have a clue why /etc/rc.d/foo rcvar prints a leading '$' >>>>> before the variable name? Doesn't make much sense with /bin/sh. >>>> Sorry for the late reply. According to the CVS history, the code >>>> was just imported from NetBSD. Perhaps it's too late to change it >>>> as people are likely to have workarounds for it already. Of course, >>>> $foo_enable=YES looks ugly and has a different meaning in sh(1). >>> Well, it may be worth fixing in HEAD even if we don't MFC the change. >> Then just do it! Well, if no serious objections appear in a >> reasonable period of time. Personally, I'm happy with the change >> -- I'm just not enough unhappy with the current bogosity. :-) >> > Err, why is it a good idea to break compatability with NetBSD? > > This means that tools written for rc.d that use rcvar (chkconfig clone for > example) have to have behavior written for both NetBSD and FreeBSD instead > of just having consistent behavior. Not sure what you're thinking about. But if it's wrong, it must be fixed. If this chkconfig clone uses rcvar command output redirected to rc.conf, it's likely to do 's/^\$//' and it won't break anything. Would you care to elaborate a bit more? -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFagjdMxEkbVFH3PQRCrieAJ41+0svaemL2FG69FLDxkgePagxQQCeINx0 ql+zs2zD/SYY6La0VJviC3Y= =KGog -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?456A08DD.2080205>