Date: Tue, 12 Dec 2006 15:57:39 +0100 From: Stefan Farfeleder <stefan@fafoe.narf.at> To: Luigi Rizzo <rizzo@icir.org> Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20061212145738.GC915@lizard.fafoe.narf.at> In-Reply-To: <20061212064246.A62035@xorpc.icir.org> References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> <20061212062445.A61903@xorpc.icir.org> <20061212143113.GA54209@cicely12.cicely.de> <20061212064246.A62035@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 12, 2006 at 06:42:46AM -0800, Luigi Rizzo wrote: > [moving to arch] > > sorry if it has been debated already, but looking in the > network code it seems that checks for architectures that > need strong alignment are done through a sequence of > > #if defined(__ia64__) || defined(__blah__) || ... > > one such sequence is in net/if_loop::if_simloop(), and was > related to a problem we are having with some recent > commits to net/if_ethersubr.c > > While the easy fix (for this one) is to add > || defined(__arm__) > to the sequence, we were wondering if there is some identifier > that we can use to the purpose. > > Bernd Walter was suggesting this: > > > I would have said ALIGNBYTES != 1, but this also matches with i386. > > Guess it's time to introduce somehing like ALIGN_STRONG, or whatever > > colour fits best. > > ideas ? Architectures without strong alignment define __NO_STRICT_ALIGNMENT in <machine/_types.h>. Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212145738.GC915>