Date: Thu, 28 Dec 2006 14:50:13 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Andrey Chernov <ache@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: sysv_ipc.c broken in v1.30 (was Re: sysvshm appearse broken in -current) Message-ID: <20061228144606.N86685@fledge.watson.org> In-Reply-To: <20061228141235.GA92268@nagual.pp.ru> References: <20061216055903.GA2712@nagual.pp.ru> <20061216111656.GA7501@nagual.pp.ru> <20061216112117.P72986@fledge.watson.org> <20061216114426.GA7735@nagual.pp.ru> <20061216120746.E72986@fledge.watson.org> <20061216125136.GA1094@nagual.pp.ru> <20061216125419.J72986@fledge.watson.org> <20061217153914.GA30048@nagual.pp.ru> <20061221233855.GA95581@nagual.pp.ru> <20061222204908.C65423@fledge.watson.org> <20061228141235.GA92268@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 28 Dec 2006, Andrey Chernov wrote:
> On Fri, Dec 22, 2006 at 08:51:05PM +0000, Robert Watson wrote:
>> I return from Oxford. If you want, you can try removing the ipcperm() call
>> from shmget_existing() and restore the sysv_ipc.c change and see how that
>> works for you?
>
> Yes, it works, all t-shm tests passed.
I believe this check is:
(1) Gratuitous. Applications do not expect it to occur, the specs (in as much
as they exist) don't expect it to happen, etc. Likewise, this is simply a
name space lookup that doesn't affect actual right to access the
underlying object (unlike, say, a file pathname).
(2) Incorrect. Unlike all other calls to the check routine, it doesn't pass
in the specific rights being requested, it passes in a mode mask. There
are some cases where the flag mask is masked with 0700 and then pass it
in, and it could be that making the same change here does the right thing.
Both of these suggest removing the check, but I want to do a bit more reading
before I do that, and run some tests on other platforms to confirm my reading.
Robert N M Watson
Computer Laboratory
University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061228144606.N86685>