Date: Thu, 18 Jan 2007 09:21:27 -0500 From: John Baldwin <jhb@freebsd.org> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 113105 for review Message-ID: <200701180921.27766.jhb@freebsd.org> In-Reply-To: <200701181040.l0IAei63036714@repoman.freebsd.org> References: <200701181040.l0IAei63036714@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 18 January 2007 05:40, Hans Petter Selasky wrote: > http://perforce.freebsd.org/chv.cgi?CH=113105 > > Change 113105 by hselasky@hselasky_mini_itx on 2007/01/18 10:40:02 > > Use unsigned type for counting the number of devices. uint32_t should be used when you really need a 32-bit type. For simple counting you should use either 'int' or 'u_int'. > Affected files ... > > .. //depot/projects/usb/src/sys/kern/subr_bus.c#5 edit > > Differences ... > > ==== //depot/projects/usb/src/sys/kern/subr_bus.c#5 (text+ko) ==== > > @@ -1848,8 +1848,8 @@ > int > device_get_children(device_t dev, device_t **devlistp, int *devcountp) > { > - int count; > - int n; > + uint32_t count; > + uint32_t n; > device_t child; > device_t *list; > > -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701180921.27766.jhb>