Date: Wed, 07 Mar 2007 17:29:36 +0100 From: Dennis Berger <db@bsdsystems.de> To: doug steinwand <dzs-pr@dzs.fx.org> Cc: bug-followup@FreeBSD.org, freebsd-geom@freebsd.org Subject: Re: kern/104389: [geom] [patch] sys/geom/geom_dump.c doesn't encode XML entities Message-ID: <45EEE870.2040706@bsdsystems.de> In-Reply-To: <20070307151026.GA55527@dzs.fx.org> References: <45ED8E88.5080400@nipsi.de> <20070307151026.GA55527@dzs.fx.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes I found this version much better than the one before. regards, -Dennis doug steinwand schrieb: > * Dennis Berger <db@nipsi.de> [2007-03-06 16:53:44 +0100]: > >> This way we can escape all illegal characters. >> What do you suggest? >> > > The gstat and other geom applications basically use expat to parse > the equivalent of "sysctl -b kern.geom.confxml". This output does > not have an encoding specified, so expat accepts only ASCII. As > such, bytes greater than 0x7e must be encoded. > > http://skew.org/xml/tutorial/ > http://www.w3.org/TR/1998/REC-xml-19980210 > > Attached is a patch which attempts to output valid XML for all cases > (any value between 0x00 and 0xff). One issue is that many bytes > between 0x00 and 0x1f have no valid XML coding, so this patch > replaces them with '?' (such things should not appear in geom names, > though). > > Also, it seems that expat is attempting to convert bytes from > iso-8859-1 into utf8 characters, so gstat and glabel output may > look weird. > > - doug > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-geom@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" -- Dennis Berger BSDSystems Eduardstrasse 43b 20257 Hamburg Phone: +49 (0)40 54 00 18 17 Mobile: +49 (0) 179 123 15 09 E-Mail: db@bsdsystems.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45EEE870.2040706>