Date: Wed, 02 May 2007 02:41:03 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Brian Somers <brians@ca.sophos.com> Cc: gnome@freebsd.org Subject: Re: Fix for x11/gnome-screensaver Message-ID: <1178088063.28923.0.camel@shumai.marcuscom.com> In-Reply-To: <20070501232448.1239bbd3@dev.lan.Awfulhak.org> References: <20070501123616.6b43b4de@conflict.ca.sophos.com> <20070501232448.1239bbd3@dev.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-vWbuNePQgJWVeeEH3j3A
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Tue, 2007-05-01 at 23:24 -0700, Brian Somers wrote:
> On Tue, 1 May 2007 12:36:16 -0700 Brian Somers <brians@ca.sophos.com> wro=
te:
> > Hi,
> >=20
> > Could someone apply the attached patch for x11/gnome-screensaver
> > or approve it for me to commit?
> >=20
> > TIA.
> >=20
> > --=20
> > Brian Somers Tel: +1 604 484 6434
> > Mob: +1 604 315 1343
> > Sophos - security and control Web: www.sophos.com
> >=20
> > Index: Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /usr/home/ncvs/ports/x11/gnome-screensaver/Makefile,v
> > retrieving revision 1.23
> > diff -u -r1.23 Makefile
> > --- Makefile 11 Apr 2007 13:32:59 -0000 1.23
> > +++ Makefile 1 May 2007 19:34:17 -0000
> > @@ -47,7 +47,7 @@
> > CONFIGURE_ARGS+=3D --disable-pam
> > .endif
> > =20
> > -pre-install:
> > +pre-su-install:
> > @${CP} ${.CURDIR}/pkg-plist ${PLIST}
> > @cd ${XSCREENSAVER_DIR} && ${FIND} -s * -maxdepth 1 -type f -name "*.=
xml" | \
> > ${GREP} -Ev ${XSCREENSAVER_EXCLUDE} | \
> > @@ -55,7 +55,7 @@
> > ${SED} -e 's:[.]xml$$:.desktop:' >> ${PLIST}
> > @${ECHO_CMD} @dirrm ${SCREENSAVER_DIR} >> ${PLIST}
> > =20
> > -post-install:
> > +post-su-install:
> > ${CHOWN} root ${PREFIX}/libexec/gnome-screensaver-dialog
> > ${CHMOD} +s ${PREFIX}/libexec/gnome-screensaver-dialog
> > ${MKDIR} ${PREFIX}/${SCREENSAVER_DIR}
>=20
> Hmm, it seems that post-su-install doesn't exist and
> post-install is run with root credentials, so please
> disregard the second part of the patch.
>=20
> The pre-install -> pre-su-install change is still
> required though...
Please see my earlier response to you. I don't see why pre-su-install
is required here.
Joe
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-vWbuNePQgJWVeeEH3j3A
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQBGODJ+b2iPiv4Uz4cRAuZ8AJ4+69MNWecoaO58ueqVYFyCYYj1SwCfXD50
V97BSdhLYEf8CAvw1S5cvbU=
=HpoZ
-----END PGP SIGNATURE-----
--=-vWbuNePQgJWVeeEH3j3A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1178088063.28923.0.camel>