Date: Fri, 20 Jul 2007 20:38:58 +0200 From: Teufel <bsd@kuehlbox.de> To: current@FreeBSD.org Subject: Re: NET_NEEDS_GIANT removal Message-ID: <46A10142.1030807@kuehlbox.de> In-Reply-To: <200706040941.16507.hselasky@c2i.net> References: <20070601105521.D77697@fledge.watson.org> <20070601125901.W92469@fw.reifenberger.com> <20070601.131946.71174943.imp@bsdimp.com> <200706040941.16507.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello everyone, is there any issue to replace i4b on -CURRENT with HPS one? I have had compiled these patches now for several years in my productions servers and had never issues with it. With all due respect to the authors, the current i4b looks very outdated. If HPS i4b is already GIANT-free, probably it would be a better idea to review the code and give some advices what needs to be fixed. Isdn in germany is still commonly used. I am currently installing some machines todo pf-stress-tests and could add a couple of isdn devices too if needed. Hans Petter Selasky wrote: > On Friday 01 June 2007 21:19, Warner Losh wrote: > >>>> i4b - ISDN implementation >>>> >>> ... >>> >>> Before deleting we should replace i4b with the one from hps. >>> http://www.selasky.org/hans_petter/isdn4bsd/index.html >>> It was said to be GIANT free last time I asked. >>> >> Who has reviewed this code? Last time I checked, it had all kinds of >> Byzantine construts that made it extremely difficult to penetrate. >> There were very few comments and it implemented state machines as >> computed gotos :-(. The cure would be worse than the disease. >> > > When was last time? > > The code is constantly changing during the years. > > --HPS >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46A10142.1030807>