Date: Sat, 16 Jun 2007 00:36:30 +0800 From: Xin LI <delphij@delphij.net> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: Xin LI <delphij@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: annoying behavior in less(1) after v403 import Message-ID: <4672C00E.50908@delphij.net> In-Reply-To: <20070615104612.GA40097@rambler-co.ru> References: <4671C5AF.9040203@uffner.com> <4671CD22.5030507@samsco.org> <20070615104612.GA40097@rambler-co.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Ruslan,
Ruslan Ermilov wrote:
> On Thu, Jun 14, 2007 at 05:20:02PM -0600, Scott Long wrote:
[...]
> Previously -f, -E, -m and -G were enforced in FreeBSD version
> of more(1). New version of less(1) supports the "more" mode
> natively, and by default enforces -E and -m options (see the
> COMPATIBILITY WITH MORE section in a manpage). The -f and -G
> options are not enforced. Note that -f is now able to read
> directories too. The patch to restore the lost compatibility
> with our previous version of more(1) is trivial (see below),
> but I'm not sure it's worth to diverge from vendor since there
> are ways to achieve the desired compatibility level on a per
> user basis without the need to modify the sources, by setting
> the MORE environment variable appropriately, e.g.:
>
> % setenv MORE -f
>
> %%%
> Index: main.c
> ===================================================================
> RCS file: /home/ncvs/src/contrib/less/main.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 main.c
> --- main.c 4 Jun 2007 01:43:11 -0000 1.6
> +++ main.c 15 Jun 2007 10:22:11 -0000
> @@ -135,6 +135,9 @@ main(argc, argv)
>
> init_prompt();
>
> + if (less_is_more)
> + scan_option("-fG");
> +
> s = lgetenv(less_is_more ? "MORE" : "LESS");
> if (s != NULL)
> scan_option(save(s));
> %%%
Sounds sensible to me. I think for the sake of POLA we do want to put
this on -HEAD (the file is already off the vendor branch anyway), please
feel free to commit it, thanks!
Cheers,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4672C00E.50908>