Date: Wed, 4 Jul 2007 09:21:27 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: W Forms <wforms@safe-mail.net>, freebsd-net@FreeBSD.org Subject: Re: kern/112710: [re] if_re driver detects incorrect b243a405a405 MAC address on SMC9452TX-1 pci gigabit cards Message-ID: <20070704002127.GA72486@cdnetworks.co.kr> In-Reply-To: <20070703152706.GA32357@verio.net> References: <200707031100.l63B0GV0020511@freefall.freebsd.org> <20070703152706.GA32357@verio.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 03, 2007 at 10:27:07AM -0500, David DeSimone wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > W Forms <wforms@safe-mail.net> wrote: > > > > I don't really understand this, since from what I can see all that > > Pyun YongHyeon's changes do is replacing a constant value of 6 and 8 > > with macros containing the value of 6 and 8. > > Here's the patch as I recall it: > > > - sc->rl_eewidth = 6; > + sc->rl_eewidth = RL_9356_ADDR_LEN; > re_read_eeprom(sc, (caddr_t)&re_did, 0, 1); > if (re_did != 0x8129) > - sc->rl_eewidth = 8; > + sc->rl_eewidth = RL_9346_ADDR_LEN; > > /* 9346 EEPROM commands */ > +#define RL_9346_ADDR_LEN 6 /* 93C46 1K: 128x16 */ > +#define RL_9356_ADDR_LEN 8 /* 93C56 2K: 256x16 */ > > It looks to me like 6 was replaced with 8, and vice versa. In other > words, a real bug fix. :) > Yep. Previously it tried to probe 93C46 EEPROM first. Now it probes 93C56 before going back to 93C46. I'll ask for re approval to commit. Thanks for testing and report! -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704002127.GA72486>