Date: Sun, 26 Aug 2007 17:49:11 +0200 From: Peter Schuller <peter.schuller@infidyne.com> To: vd@FreeBSD.org Cc: bug-followup@FreeBSD.org, freebsd-python@FreeBSD.org Subject: Re: ports/115761: new port: devel/py-boto Message-ID: <20070826154911.GA77348@hyperion.scode.org> In-Reply-To: <200708240648.l7O6mWrA052725@freefall.freebsd.org> References: <200708240648.l7O6mWrA052725@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sorry about the incompleteness/incorrectness of the submission. Been a while since I submitted a port last, and I should have taken more time to ensure I was complying. > * Add the heading comments just as in any other port. Use $FreeBSD$, it will > be expanded automatically Done. > * Use ports-mgmt/portlint to check the port before submitting the shar, > it should produce no warnings or fatals Done. It correctly points out the non-redundancy of MASTER_SITES. I'd be happy to host a mirror on distfiles.scode.org if that is considered appropriate. Should I do that and re-submit? > * pkg-plist must be sorted alphabetically, not like this: > %%PYTHON_SITELIBDIR%%/boto/ec2/__init__.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/connection.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/image.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/instance.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/keypair.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/securitygroup.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/__init__.pyo Done. > * Explain why is files/patch-setup.py needed? What happens, without that > patch? Added comment to patch. It got installed as PREFIX/bin/test.py which is a very generic name. In the interest of minimal downstream patching/maintenance, I just commented it out rather than renamed it or made it be installed elsewhere, given that it is not likely to be very interesting for users of the port. > * Remove the trailing space after "Mechanical Turk" in pkg-descr Done. > * Submit the shar as an attachment so it is available in the PR system > even after you remove it from your site. Uploading it into your site > and posting a link makes it easier to fetch, if you are not bothered, > do both :-) Attached. Also available as: http://distfiles.scode.org/ports/py-boto-newport-2.shar -- / Peter Schuller PGP userID: 0xE9758B7D or 'Peter Schuller <peter.schuller@infidyne.com>' Key retrieval: Send an E-Mail to getpgpkey@scode.org E-Mail: peter.schuller@infidyne.com Web: http://www.scode.org --VS++wcV0S1rZb1Fb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070826154911.GA77348>