Date: Wed, 12 Mar 2008 18:31:36 +0100 From: Benjamin Lutz <mail@maxlor.com> To: freebsd-ports@freebsd.org Cc: RW <fbsd06@mlists.homeunix.com> Subject: Re: ports/113132 (make -j patch) Message-ID: <200803121831.43296.mail@maxlor.com> In-Reply-To: <20080312154725.705e141c@gumby.homeunix.com.> References: <200803121311.51383.mail@maxlor.com> <20080312154725.705e141c@gumby.homeunix.com.>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1857949.ls2XFFsIdn Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 12 March 2008 16:47:25 RW wrote: > On Wed, 12 Mar 2008 13:11:51 +0100 > Benjamin Lutz <mail@maxlor.com> wrote: > > This patch has been sitting in GNATS for a couple of months now: > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/113132 > > > > I've received a few mails from people reporting success, and none > > reporting that bad things have happened. Is it possible to get this > > committed? > > I'm not keen on the way MAKE_JOBS_WHITELIST is implemented as a list. > It seems to be out of step with the way similar problems are handled > elsewhere. I would have expected a simple flag that can be set per > port using portsconf, pkgtools.conf, etc. portconf and pkgtools.conf are files that are used by tools external to=20 the base ports system (portmaster and portupgrade). The ports makefiles=20 do not read them. The traditional place to put port configuration info=20 is /etc/make.conf. Since using the whitelist is not intended to be an officially supported=20 feature, but only exists to make life a bit easier for people who are=20 debugging the ports or willing to experiment, I expect that on 99% of=20 =46reeBSD systems, the whitelist will not be specified at all. I=20 therefore see no reason to increase the complexity of the whitelist=20 parsing code by introducing non-make-compatible syntax. > This is more of a bikeshed issue, but the term MAKE_JOBS reflects > implementation (gmake -j) rather than function, and its meaning isn't > obvious the way something like PARALLEL_BUILD would be. The patch used the name PARALLEL in a previous incarnation; MAKE_JOBS=20 was chosen to avoid misunderstandings and name conflicts with ongoing=20 work to allow several ports to be built in parallel, independently of=20 each other. MAKE_JOBS might not have as nice a ring to it, but the=20 intention is clearer. Cheers Benjamin --nextPart1857949.ls2XFFsIdn Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQBH2BN/zZEjpyKHuQwRAo7XAJ9ok5Cvcrqre9Hnab6Zrg4W7rv5QQCfd5W5 WSEAjOAwb6p/isbBQdhMAw8= =JF0i -----END PGP SIGNATURE----- --nextPart1857949.ls2XFFsIdn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803121831.43296.mail>