Date: Thu, 17 Jul 2008 05:34:21 -0700 (PDT) From: =?iso-8859-1?Q?Arne_W=F6rner?= <arne_woerner@yahoo.com> To: gavin@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/100018: newsyslog(8) does not check size if time_at is used Message-ID: <608836.52903.qm@web30301.mail.mud.yahoo.com> In-Reply-To: <200807171211.m6HCBYfO092980@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--- On Thu, 7/17/08, gavin@FreeBSD.org <gavin@FreeBSD.org> wrote:
> - } else if (ent->hours <= 0 &&
> (ent->flags & CE_TRIMAT)) {
> + } else if ((ent->hours <= 0 &&
> (ent->flags & CE_TRIMAT)) &&
> + check_time_rotate) {
>
thx for ur effort...
unfortunately i do not have any fbsd box currently...
but i did a lazy code inspection and think, that it looks ok...
but:
} else if ((ent->flags & CE_TRIMAT) && check_time_rotate) {
should suffice, since "check_time_rotate" cant become 1 if "ent->hours > 0" or can it? not really sure... :)
-arne
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?608836.52903.qm>