Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 02 Aug 2008 12:24:54 -0700
From:      Tim Kientzle <kientzle@freebsd.org>
To:        Anselm Strauss <strauss@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 146346 for review
Message-ID:  <4894B486.8000102@freebsd.org>
In-Reply-To: <200807312046.m6VKkKc1042376@repoman.freebsd.org>
References:  <200807312046.m6VKkKc1042376@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Anselm Strauss wrote:
> http://perforce.freebsd.org/chv.cgi?CH=146346

> -	/* assertEqualInt(i4(p + 16), XXXX); */ /* CRC-32 */
> +	assertEqualInt(i4(p + 16), crc32(0, &data, sizeof(data))); /* CRC-32 */

This is a nice, straightforward way to test this functionality.
Good work.

It would be nice to change the test code to write the data
as two operations:  write the first 5 bytes, maybe, then
write the rest.  That would test the CRC code a little more
thoroughly.

Tim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4894B486.8000102>