Date: Thu, 25 Sep 2008 12:43:46 -0700 From: Navdeep Parhar <nparhar@gmail.com> To: cvs-src@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/gdb/kgdb kld.c Message-ID: <20080925194346.GA20498@insightsol.com> In-Reply-To: <200809251932.m8PJWJxr073365@repoman.freebsd.org> References: <200809251932.m8PJWJxr073365@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 25, 2008 at 07:32:03PM +0000, John Baldwin wrote: > jhb 2008-09-25 19:32:03 UTC > > FreeBSD src repository > > Modified files: > gnu/usr.bin/gdb/kgdb kld.c > Log: > SVN rev 183359 on 2008-09-25 19:32:03Z by jhb > > Use existing GDB routines for parsing the section table of klds in > the 'add-kld' command instead of doing it more by hand. > > MFC after: 1 week > > Revision Changes Path > 1.10 +23 -36 src/gnu/usr.bin/gdb/kgdb/kld.c This can lead to a bad free + core dump as I'd mentioned here: http://lists.freebsd.org/pipermail/freebsd-hackers/2008-September/026024.html Please initialize sections and sections_end to NULL. 205c204,205 < struct section_table *sections, *sections_end, *s; --- > struct section_table *sections = NULL, *sections_end = NULL, *s; Regards, Navdeep
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080925194346.GA20498>