Date: Sun, 29 Mar 2009 22:39:59 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports@FreeBSD.org Subject: Re: HEADS UP multi processor compilations for everyone Message-ID: <1238359199.68837.10.camel@hood.oook.cz> In-Reply-To: <20090327124838.GM1964@hades.panopticon> References: <1237901632.1849.19.camel@pav.hide.vol.cz> <20090326174632.GB19722@hades.panopticon> <1238108060.268.1.camel@hood.oook.cz> <20090327010223.GK1964@hades.panopticon> <1238139614.71596.2.camel@hood.oook.cz> <20090327124838.GM1964@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-RTj7KycMDi5mD/BaAWcO
Content-Type: text/plain; charset="ISO-8859-2"
Content-Transfer-Encoding: quoted-printable
Dmitry Marakasov p=ED=B9e v p=E1 27. 03. 2009 v 15:48 +0300:
> * Pav Lucistnik (pav@FreeBSD.org) wrote:
>=20
> > > second
> > > also improves MAKE_JOBS_* handling, shortening it a bit and exposing
> > > MAKE_JOBS_NUMBER to the ports, so it can be used for other build syst=
ems
> > > without having to parse out -j from _MAKE_JOBS (and defaults to 1 if
> > > jobs support is disabled).
> >=20
> > This one I cannot accept, because it adds back !=3D call I made a big
> > effort to avoid. We can't have one !=3D call per port during building
> > INDEX.
>=20
> Understood. I still think it'd be nice to expose number of jobs as a
> plain number to the ports.
If you figure it out without !=3D call, let me know.
> > > Also, [ x !=3D x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsaf=
e,
> > > and inconsistent to IGNORE/BROKEN/... vars, in which we don't use
> > > quotes.
> >=20
> > It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the
> > parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW?
> > Because they are present in do-configure target too - should they be
> > removed there too?
>=20
> I just didn't like them :)=20
Good enough reason for me :)
> Are they really needed around single command?
No idea.
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
On real UNIX, /usr/bin/more prints -More-.
--=-RTj7KycMDi5mD/BaAWcO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAknP3J8ACgkQntdYP8FOsoJ9JwCgxBjbeqfXuP1hGAySGi+JQIB0
RMwAoKi5dT7sR4brxzXmgUX5u0yjNuZ3
=Jdcj
-----END PGP SIGNATURE-----
--=-RTj7KycMDi5mD/BaAWcO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1238359199.68837.10.camel>