Date: Sat, 09 May 2009 06:21:26 -0700 From: Julian Elischer <julian@elischer.org> To: Marko Zec <zec@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org>, Robert Watson <rwatson@freebsd.org> Subject: Re: PERFORCE change 161828 for review Message-ID: <4A058356.2080306@elischer.org> In-Reply-To: <200905091307.n49D7hN7057989@repoman.freebsd.org> References: <200905091307.n49D7hN7057989@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Marko Zec wrote: > http://perforce.freebsd.org/chv.cgi?CH=161828 > > Change 161828 by zec@zec_tpx32 on 2009/05/09 13:07:41 > > Don't call if_dead() in if_detach() in options VIMAGE builds, > given that we may wish to reattach the ifnet to another vnet > after if_detach() is done, and if_dead() would render the > ifnet useless. > > Pointed out by: rwatson > > Affected files ... > > .. //depot/projects/vimage-commit2/src/sys/net/if.c#57 edit > > Differences ... > > ==== //depot/projects/vimage-commit2/src/sys/net/if.c#57 (text+ko) ==== > > @@ -950,8 +950,12 @@ > > /* > * Prevent further calls into the device driver via ifnet. > + * XXX temporarily disabled in VIMAGE builds as we may need to > + * to reattach the ifnet to another vnet. > */ > ++#ifndef VIMAGE > if_dead(ifp); > ++#endif > > /* > * Remove link ifaddr pointer and maybe decrement if_index. I may try to do the if_vmove() function today if I can get a P4 tree up on my laptop..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A058356.2080306>