Date: Mon, 16 Nov 2009 16:21:00 -0500 From: Jim Wilcoxson <prirun@gmail.com> To: gary.jennejohn@freenet.de Cc: volker@vwsoft.com, freebsd-hackers@freebsd.org Subject: Re: acl_from_text leaking memory Message-ID: <c5830b750911161321m3c8edabas58a88df2e2832b6d@mail.gmail.com> In-Reply-To: <20091116214202.480a0aa7@ernst.jennejohn.org> References: <c5830b750911150804i694b00aai891819242816e89c@mail.gmail.com> <c5830b750911150847r3698b21ey819d4de3312ef78d@mail.gmail.com> <4B01B23F.8040002@vwsoft.com> <20091116214202.480a0aa7@ernst.jennejohn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The man page is correct and should not be changed. In the example program I submitted, it does call acl_free; this is not where the leak occurs. The leak occurs because of a temporary string that acl_from_text allocates to parse the text. Jim On 11/16/09, Gary Jennejohn <gary.jennejohn@freenet.de> wrote: > On Mon, 16 Nov 2009 21:12:47 +0100 > volker@vwsoft.com wrote: > >> you may want to have a look at the manpage acl_from_text(3): >> >> "...This function may cause memory to be allocated. The caller should >> free any releasable memory, when the new ACL is no longer required, by >> calling acl_free(3) with the (void *)acl_t as an argument." >> >> Please use an acl_free(void *obj_p) call afterwards to avoid leaking >> memory. >> > > The suggested fix was appplied to HEAD today. Apparently, the man page > should > now be updated. > > --- > Gary Jennejohn >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c5830b750911161321m3c8edabas58a88df2e2832b6d>