Date: Wed, 2 Dec 2009 15:59:19 +0200 From: Jaakko Heinonen <jh@FreeBSD.org> To: Scott Long <scottl@samsco.org> Cc: scsi@freebsd.org Subject: Re: cd(4) M_WAITOK allocations with periph lock held Message-ID: <20091202135919.GA3675@a91-153-117-195.elisa-laajakaista.fi> In-Reply-To: <20091201142930.I99667@pooker.samsco.org> References: <20091201180524.GB7961@a91-153-117-195.elisa-laajakaista.fi> <20091201142930.I99667@pooker.samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 2009-12-01, Scott Long wrote: > How about the attached match instead. It refactors the code so that > unlocks aren't needed. Looks OK to me. Some nits below. > bailout: > + xpt_release_ccb(ccb); > + cam_periph_unlock(periph); > + The file seems to have an empty line after labels in other places. Maybe put one here too. > bailout: > > + xpt_release_ccb(ccb); > + cam_periph_unlock(periph); You can remove the now unused "bailout:" label from cdsendkey(). Do you want to commit it? Thanks. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091202135919.GA3675>