Date: Fri, 19 Mar 2010 21:20:47 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: [zfs] attach by name/uuid still attaches wrong device Message-ID: <20100319202047.GA1733@garage.freebsd.pl> In-Reply-To: <20100302103826.14273mzlwp38550k@webmail.leidinger.net> References: <4B8B5780.2050601@jrv.org> <20100302103826.14273mzlwp38550k@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2010 at 10:38:26AM +0100, Alexander Leidinger wrote: > Quoting "James R. Van Artsdalen" <james-freebsd-fs2@jrv.org> (from =20 > Sun, 28 Feb 2010 23:58:24 -0600): >=20 > >I don't think it's possible to do this right in vdev_geom.c: there's no > >way to guess what is intended without a hint from higher ZFS layers as > >to which drives should be found and which are new. >=20 > There is a way: do not attach blindly. The same code was used for 'zpool import' and 'zpool create', so ignoring guids was needed to make creation work. Fortunately I found solution today by looking at different part of ZFS. I can distinguish creation from import by looking at vd->vdev_spa->spa_load_state. When it is equal to SPA_LOAD_NONE we're creating a pool and it is not, we're importing. This should be fixed now, see @205346. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkuj3J8ACgkQForvXbEpPzQSHQCg3XJGn31yFsURDGGFG7Rq7N9y WHUAmgNO/O9zI3EyR5Uxb6ODOdg2jkGE =RiCK -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100319202047.GA1733>