Date: Mon, 29 Mar 2010 18:18:28 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: John Baldwin <jhb@freebsd.org> Cc: Petr Lampa <lampa@fit.vutbr.cz>, freebsd-current@freebsd.org Subject: Re: Possible error in nfs_nfsdserv.c? Message-ID: <Pine.GSO.4.63.1003291816310.15806@muncher.cs.uoguelph.ca> In-Reply-To: <201003291216.23887.jhb@freebsd.org> References: <20100326162406.GA43912@fit.vutbr.cz> <Pine.GSO.4.63.1003270930460.12032@muncher.cs.uoguelph.ca> <201003291216.23887.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 29 Mar 2010, John Baldwin wrote: >> >> I've cc'd freebsd-current, so that anyone conversant with the FreeBSD >> VFS can jump in here. Am I right to assume that VOP_LOOKUP() for CREATE >> will set SAVENAME when returning error == 0? > > No, the caller has to set that flag. Some filesystems set it internally to > force the name to be saved (e.g. the NFS client), but there is nothing in the > VFS layer itself that sets it that I can see. > Thanks John. I spotted the comment in vfs_lookup.c that basically said that, this morning. I'll fix up the experimental server soon, although it seems that ufs and zfs usually set SAVENAME for the CREATE cases, which is why I've never seen the panic. rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.63.1003291816310.15806>