Date: Thu, 01 Apr 2010 13:33:10 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: imp@freebsd.org, rwatson@freebsd.org, gary.jennejohn@freenet.de, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review Message-ID: <20100401133310.194173uurnj5nq4g@webmail.leidinger.net> In-Reply-To: <20100330143824.252520tulyv7bxes@webmail.leidinger.net> References: <20100326101524.15695bisy2324t8g@webmail.leidinger.net> <20100326.093717.857133809997909007.imp@bsdimp.com> <20100326171241.16524bklcroedou8@webmail.leidinger.net> <20100326.102344.364422370204095721.imp@bsdimp.com> <20100327101846.5b4d6b18@ernst.jennejohn.org> <20100330143824.252520tulyv7bxes@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Alexander Leidinger <Alexander@Leidinger.net> (from Tue, 30 Mar 2010 14:38:24 +0200): > http://www.leidinger.net/test/ctf4.diff > > Changes to previous one: > - added @ to hide the CTF stuff > - man-page (to test: "groff -mdoc -Tascii /path/to/build.7 | less") > > Someone with mdoc-fu should have a look if I got it right, the > others please have a look if the place in the man-page pleases you. > > The changed commit log would be: > ---snip--- > WITH_CTF can now be specified in src.conf (not recommended, there > are some problems with static executables), make.conf (would also > affect ports which do not use GNU make and do not override the > compile targets) or in the kernel config (via "makeoptions > WITH_CTF=yes"). > > Additional (related) changes: > - propagate WITH_CTF to module builds > - do not add -g to the linker flags, it's a noop there anyway > (at least according to the man page of ld) > - do not add -g to CFLAGS unconditionally > we need to have a look if it is really needed (IMO not) or if there > is a way to add it only when WITH_CTF is used > > Note: ctfconvert / ctfmerge lines will not appear in the build output, > to protect the innocent (those which do not build with WITH_CTF would > see the shell-test and may think WITH_CTF is used). > > Reviewed by: imp, jhb, scottl (earlier version) > Discussed on: arch@ > ---snip--- > > What about Friday morning (GMT+2) for a commit date (if nobody > complains): not long enough for review or is it OK? Nobody complained so far, so I try to commit this tomorrow. Note: the date in the man page will be bumped (in cases someone notices that this is missing in the patch). Bye, Alexander. -- I go on working for the same reason a hen goes on laying eggs. -- H. L. Mencken http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100401133310.194173uurnj5nq4g>