Date: Wed, 16 Jun 2010 15:07:57 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: Dima Panov <fluffy@freebsd.org> Cc: freebsd-ports-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: ports/147899: [NEW PORT] multimedia/kplayer-kde4: Movie player based on mplayer Message-ID: <4C18BE9D.2080406@icyb.net.ua> In-Reply-To: <201006162027.54664.fluffy@freebsd.org> References: <201006160537.o5G5bK8B002589@trant.local.> <201006162027.54664.fluffy@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 16/06/2010 12:27 Dima Panov said the following:
>
> Some errors in port, regarding to docs and build process
> By kde conventions, docs should be installed under
> share/doc/HTML/${LANG}/${PORTNAME} instead of
> share/doc/HTML/${LANG}
>
> Also, don't try to remove common dirs via @dirrm, use @dirrmtry
>
> Diff for your port attached, please review
Dima,
thanks a lot!
Looks very good.
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C18BE9D.2080406>