Date: Fri, 30 Jul 2010 13:45:54 +0530 From: "Jayachandran C." <c.jayachandran@gmail.com> To: "M. Warner Losh" <imp@bsdimp.com>, jmallett@freebsd.org Cc: freebsd-mips@freebsd.org Subject: Re: Support for 64bit userspace. Message-ID: <AANLkTimOM-LmBChHPgU%2Bqa7Q_YFwc5ZYv7JkOfiV3FDU@mail.gmail.com> In-Reply-To: <20100729.131134.4959786895411328.imp@bsdimp.com> References: <AANLkTikZKS8iuST1dp5yfo6P6kaif4b1YzsKAskk_wB=@mail.gmail.com> <AANLkTinXdCLinp=07dsPYs3qr7nWJ6nZzKF5DV=z1R59@mail.gmail.com> <AANLkTinwi7v3wANCd5EGA9GHuWUrnAEP3Rq6EedGpGKe@mail.gmail.com> <20100729.131134.4959786895411328.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 30, 2010 at 12:41 AM, M. Warner Losh <imp@bsdimp.com> wrote: > In message: <AANLkTinwi7v3wANCd5EGA9GHuWUrnAEP3Rq6EedGpGKe@mail.gmail.com= > > =A0 =A0 =A0 =A0 =A0 =A0Juli Mallett <jmallett@FreeBSD.org> writes: > : On Thu, Jul 29, 2010 at 01:15, Jayachandran C. <c.jayachandran@gmail.co= m> wrote: > : > I kept the 32 bit pmap.c code untouched so that I don't have to deal = with > : > the breakage there during the early 64bit changes. > : > I will check in the other changes now, and will do another round of w= ork on > : > pmap.c/pmap64.c to see if it can be merged (and eliminate the config > : > option). > : > : Hmm, hopefully the changes will be well-isolated and any abstractions > : will be right for 32-bit and 64-bit both. =A0One of the problems with > : two files is that when they are merged, which it sounds like you think > : is inevitable, we lose the change history for that file. =A0And if > : they're in the same file, you don't need an option, just __mips_n64. > > I'd prefer one file as well... I will look at merging them without too many ifdefs. Another possibility is to have a pmap.c, pmap32.c and pmap64.c, so that the common code is not duplicated, but that too (as far as I can see) will require a config option. Also, I've been checking in the other pieces of 64 bit support that I had posted here. I've broken down the patches further so that they are be obvious (and easy to revert if it affects anything). I am not planning to check-in the pmap changes for 3 level page tables now, will post it again for review once I see what level of merge can be done. JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimOM-LmBChHPgU%2Bqa7Q_YFwc5ZYv7JkOfiV3FDU>