Date: Sat, 31 Jul 2010 13:33:04 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Julien Laffaye <jlaffaye@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 181582 for review Message-ID: <AANLkTimOB1u9eF9JrFyARY6R2owgDUKwESeHqrC-b6yK@mail.gmail.com> In-Reply-To: <201007292123.o6TLN3Td039516@repoman.freebsd.org> References: <201007292123.o6TLN3Td039516@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 29, 2010 at 2:23 PM, Julien Laffaye <jlaffaye@freebsd.org> wrote: > http://p4web.freebsd.org/@@181582?ac=10 > > Change 181582 by jlaffaye@jlaffaye-chulak on 2010/07/29 21:23:01 > > - Rework the fetch_archive() function to return a file descriptor of the > downloaded archive. > Reading on-the-fly doesn't work if we fetch dependencies: the remote > server close the connection because we are inactive (in fact we are > busy downloading the dependency). Reading on-the-fly could work if we > knew the dependencies, in the proper order, of the package before > downloading it (thus, download and install the dependencies first). > - While I'm here, print the progress (percentage) of the dowload. > ... > + if (archive_read_open_fd(a, fd, 10240) != ARCHIVE_OK) { > + warnx("archive_read_open_fd(): %s", archive_error_string(a)); > + retcode = 1; > + goto cleanup; Overall change looks good, but why 10240 :)? -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimOB1u9eF9JrFyARY6R2owgDUKwESeHqrC-b6yK>