Date: Sat, 18 Sep 2010 18:02:29 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: [PATCH] replace INVARIANTS+panic() with KASSERT Message-ID: <20100919010229.GB93245@dragon.NUXI.org> In-Reply-To: <20100917190907.GQ2389@deviant.kiev.zoral.com.ua> References: <20100917180738.GA51572@dragon.NUXI.org> <20100917190907.GQ2389@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 17, 2010 at 10:09:07PM +0300, Kostik Belousov wrote: > On Fri, Sep 17, 2010 at 11:07:38AM -0700, David O'Brien wrote: > Isn't this reverted ? I believe that all conditions for panics/printf > should be reverted in KASSERTs. Yes, thanks. > > -#ifdef notyet > > - if (bp) > > - brelse(bp); > > -#endif > > Please leave both notyet blocks in indir_trunc() as is. > There are patches in progress that change this fragments, and you > supposedly seen them. Will do. Do you if you will commit them soon? -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100919010229.GB93245>