Date: Tue, 19 Oct 2010 15:22:21 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org, Matthew Jacob <mj@feral.com> Subject: Re: SCSI_DELAY cleanup Message-ID: <201010191522.21357.jhb@freebsd.org> In-Reply-To: <20101019191446.GA44841@freebsd.org> References: <20101018235318.GA87158@freebsd.org> <201010191103.50986.jhb@freebsd.org> <20101019191446.GA44841@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, October 19, 2010 3:14:46 pm Alexander Best wrote:
> On Tue Oct 19 10, John Baldwin wrote:
> > On Tuesday, October 19, 2010 10:31:10 am Alexander Best wrote:
> > > On Tue Oct 19 10, Matthew Jacob wrote:
> > > > It would be an effective behavioral change for those of us who remove
> > > > that line.
> > > > Personally, I think 5 seconds is too long- even 2 seconds is more than
> > > > adequate even for moderately old 'other' hardware like scanners.
> > > >
> > > > For -current, why don't you simply remove all of the config lines and
> > > > leave the default at 2000ms?
> > >
> > > hmmm...i can only test the delay value on amd64. i was under the impression
> > > that archs like arm and mips need the longer delay.
> > >
> > > also at some locations in the code SCSI_DELAY is being set to 15000. i believe
> > > this is the case when certain drivers (cam, ahb, aha) get loaded as a kernel
> > > module, but i'm not sure. it looks like this:
> > >
> > > .if !defined(KERNBUILDDIR)
> > > opt_scsi.h:
> > > echo "#define SCSI_DELAY 15000" > ${.TARGET}
> > > .endif
> >
> > I believe this is all old history. SCSI_DELAY used to be set to 15000 in
> > GENERIC many years ago and was lowered to 5000. Most likely these Makefiles
> > were simply not updated at the time.
>
> oh i see. maybe this revised patch would be better suited then.
I think so, but you should post this to scsi@ for the best review.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010191522.21357.jhb>