Date: Fri, 4 Feb 2011 13:27:44 +0300 From: Eygene Ryabinkin <rea@freebsd.org> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: insufficient flag handling in tools/install.sh Message-ID: <WCdx7jY8CkUDEYZsZo35TNdHcug@QsmfhJNucgI88DfvPJdT1/nyboE> In-Reply-To: <20110204102221.GA41464@freebsd.org> References: <20110203194306.GA55376@freebsd.org> <tO0VRfG8IHdubUqZgtUh/v4OTF0@QsmfhJNucgI88DfvPJdT1/nyboE> <20110204102221.GA41464@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Q8BnQc91gJZX4vDc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Alexander, good day. Fri, Feb 04, 2011 at 10:22:21AM +0000, Alexander Best wrote: > hi eygene. thanks a lot for your patch. You're welcome ;)) > i made two changes: >=20 > 1) also catch the -v option for install(1). Yep. > 2) install(1) accepts multiple directories as arguments, when he -d flag = has > been specified. so i don't think it's necessary to iterate through all= the > directories passed to install.sh and invoke install(1) with only one > argument at a time. I had overlooked that, thanks for spotting. > could you take a look at the attached patch? Looks fine and works for me, thanks! --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --Q8BnQc91gJZX4vDc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iF4EAREIAAYFAk1L1KAACgkQFq+eroFS7PuCRAD8DzZ4ABG+tENiUlcsUHAlZXxc hYGmr2H2dYePvPFZfXEA/1aAF7azCnbRYisBd7dvIplwQ4hLjmPrl6NK9KQUTRwq =52Cf -----END PGP SIGNATURE----- --Q8BnQc91gJZX4vDc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?WCdx7jY8CkUDEYZsZo35TNdHcug>