Date: Fri, 25 Mar 2011 12:35:13 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexander Best <arundel@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org Subject: Re: Switching to [KMGTPE]i prefixes? Message-ID: <336A9ACD-29BF-41C9-BC25-917CC1E4587D@bsdimp.com> In-Reply-To: <20110325024658.GA19544@freebsd.org> References: <20110325002115.GA323@freebsd.org> <20110325015508.GA14565@freebsd.org> <20110325024658.GA19544@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
One difference between this patch, and the patch I came up with, was that I used arrays of character pointers to the names of the symbols to use. This got around the problem that you have with the 'shift' you had to introduce to get things more or less correct. It also made for the possibility of having different kinds of units in the future that weren't a power of 2 -1 bytes long. It also simplified the code a little. Perhaps you would consider this improvement when devising future patches. Warner On Mar 24, 2011, at 8:46 PM, Alexander Best wrote: > here is a revised patch. it also includes the necessary changes to the > humanize_number(3) man page. > > cheers. > alex > > -- > a13x > <IEC_80000_13.diff>_______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?336A9ACD-29BF-41C9-BC25-917CC1E4587D>