Date: Tue, 29 Mar 2011 11:59:00 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: wxs@FreeBSD.org Cc: freebsd-rc@FreeBSD.org Subject: Re: status cleanup Message-ID: <20110329.115900.969026047405273902.hrs@allbsd.org> In-Reply-To: <20110329024441.GA24720@atarininja.org> References: <20110319012959.GA39929@atarininja.org> <20110319013155.GB39929@atarininja.org> <20110329024441.GA24720@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Wesley Shields <wxs@freebsd.org> wrote in <20110329024441.GA24720@atarininja.org>: wx> On Fri, Mar 18, 2011 at 09:31:55PM -0400, Wesley Shields wrote: wx> > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: wx> > > A co-worker noticed that the pf rc script has 'status' listed twice when wx> > > run without any arguments. The attached patch fixes that and two other wx> > > cases where this also happens. I've only tested the pf changes. I'd wx> > > appreciate a review of this and maybe a commit? I can file a PR if it wx> > > would make people feel better. wx> > > wx> > > I'm not subscribed to this list so I would appreciate being CC'ed on any wx> > > replies. wx> > > wx> > > -- WXS wx> > wx> > This time with the patch attached, or you can get it at: wx> > wx> > http://people.freebsd.org/~wxs/rc-status-cleanup.diff wx> > -extra_commands="status prefer_ipv6 prefer_ipv4" wx> > +extra_commands="prefer_ipv6 prefer_ipv4" For the ip6addrctl script removing "status" is wrong. This keyword is automatically added only when ${name}_program is defined and the ip6addrctl does not define it. The other two changes look good to me. If there is no objection in a day or two, I will commit them. Thank you for your report. -- Hiroki ----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk2RSvQACgkQTyzT2CeTzy2GCgCgykuFfNatnnx6bvlXkG15Uudm iEoAoIpfZ34trbbTYD3PzSqK4P7Ch4gD =NilL -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110329.115900.969026047405273902.hrs>