Date: Mon, 04 Apr 2011 09:20:08 +0300 From: Mikolaj Golub <trociny@freebsd.org> To: Victor Balada Diaz <victor@bsdes.net> Cc: Kostik Belousov <kib@FreeBSD.org>, stable@freebsd.org, Pawel Jakub Dawidek <pjd@FreeBSD.org> Subject: Re: geli(4) memory leak Message-ID: <864o6ek06f.fsf@in138.ua3> In-Reply-To: <20110403235124.GF1289@equilibrium.bsdes.net> (Victor Balada Diaz's message of "Mon, 4 Apr 2011 01:51:24 %2B0200") References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl> <86zko7nsby.fsf@kopusha.home.net> <20110403235124.GF1289@equilibrium.bsdes.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 Apr 2011 01:51:24 +0200 Victor Balada Diaz wrote: VBD> On Sun, Apr 03, 2011 at 08:43:45PM +0300, Mikolaj Golub wrote: >> >> On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: >> >> PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: >> >> For me your patch look correct. But the same issue is for read :-). Also, to >> >> avoid the leak I think we can just do g_destroy_bio() before "all sectors" >> >> check. See the attached patch (had some testing). >> >> PJD> The patch looks good. Please commit. >> >> Commited, thanks. VBD> I've been out all the weekend, so i've been unable to answer before. I'm glad VBD> it got commited and it's great you discovered and fixed the same problem on the VBD> read path. VBD> Are there any plans to MFC this? Approximately after one week. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864o6ek06f.fsf>