Date: Sat, 16 Jul 2011 11:07:39 +0300 From: Vitaly Magerya <vmagerya@gmail.com> To: Taku YAMAMOTO <taku@tackymt.homeip.net> Cc: freebsd-acpi@freebsd.org, Andriy Gapon <avg@freebsd.org> Subject: Re: (Missing) power states of an Atom N455-based netbook Message-ID: <CAL409Kw4wziCE6uZQUVZeAF1rEupc1Eex99%2B0CQ5sq9OkRpV9g@mail.gmail.com> In-Reply-To: <20110715174817.9b933756.taku@tackymt.homeip.net> References: <BANLkTim%2B1UwquMJ32WP8wZBGkYxPv78MLA@mail.gmail.com> <20110713114521.9f684b01.taku@tackymt.homeip.net> <CAL409KzJwinYQU4aqqg4khL4EmwXfFfft0=S7KwzSTyxyzue6Q@mail.gmail.com> <201107131202.53344.jkim@FreeBSD.org> <20110715174817.9b933756.taku@tackymt.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Taku YAMAMOTO <taku@tackymt.homeip.net> wrote: > Maybe we have to tell the BIOS that we are going to utilize _CST via SMI. > In fact, the major difference between mine and jkim's is that in mine > I took the following snippet (which we can find in acpi_cpu_startup_cx > function, living in sys/dev/acpica/acpi_cpu.c) out of #ifdef notyet. > > -#ifdef notyet > /* Signal platform that we can handle _CST notification. */ > if (!cpu_cx_generic && cpu_cst_cnt != 0) { > ACPI_LOCK(acpi); > AcpiOsWritePort(cpu_smi_cmd, cpu_cst_cnt, 8); > ACPI_UNLOCK(acpi); > } > -#endif > > Vitaly, could you remove the above-mentioned #ifdef-#endif pair (to activate > the code inbetween) and test jkim's patch again? It hangs on the same spot. >> Actually, I abandoned the patches and I am thinking about rewriting it >> from scratch, e.g., refactoring MI/MD support code >> (dev/acpica/acpi_cpu.c -> machine/machdep.c & acpica/acpi_machdep.c). >> Unfortunately, I don't have much time nor hardware to test, so it >> won't happen any time soon. Sorry. >> >> If anyone wants to pick it up from here, please feel free. > > [...] > > I will happily test your new patches next time. I'll provide any testing help needed as well.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAL409Kw4wziCE6uZQUVZeAF1rEupc1Eex99%2B0CQ5sq9OkRpV9g>