Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Nov 2011 19:30:20 +0000
From:      Matthew Seaman <m.seaman@infracaninophile.co.uk>
To:        Jason Helfman <jhelfman@e-e.com>
Cc:        Wesley Shields <wxs@FreeBSD.org>, freebsd-ports <freebsd-ports@FreeBSD.org>
Subject:   Re: More nitpicks from the department of redundancy department...
Message-ID:  <4ECBF84C.4050209@infracaninophile.co.uk>
In-Reply-To: <20111122172941.GA67967@dormouse.experts-exchange.com>
References:  <4EC8CC53.5000806@infracaninophile.co.uk> <CAF6rxgnHQxXBqz_R=n7HwmgTGLq0%2B_MmMwp2Si2rT%2BXHCa1i4g@mail.gmail.com> <CAF6rxgm4E%2BmjqiVxLQZJ6VPZ8OL7V=0j%2BPM9rnZpU0sPnZoLrA@mail.gmail.com> <20111122132922.GC56180@atarininja.org> <4ECBC36F.6040607@infracaninophile.co.uk> <20111122154924.GD56180@atarininja.org> <20111122172941.GA67967@dormouse.experts-exchange.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4558AC5DA2E1A8CB242E9F9C
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 22/11/2011 17:29, Jason Helfman wrote:
> On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake:
>> On Tue, Nov 22, 2011 at 03:44:47PM +0000, Matthew Seaman wrote:
>>> On 22/11/2011 13:29, Wesley Shields wrote:
>>> > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote:
>>> >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler
>>> <lists@eitanadler.com> wrote:
>>> >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman
>>> >>> <m.seaman@infracaninophile.co.uk> wrote:
>>> >>>>
>>> >>>> PORT_DBDIR?=3D /var/db/ports is the default setting in
>>> bsd.ports.mk -- the
>>> >>>> following ports redefine it to exactly the same value:
>>> >>>> [ snip ]
>>> >>>
>>> >>> Thanks for the report - I'll handle these.
>>> >>
>>> >> Sorry for the empty promise. Something came up and I won't have th=
e
>>> >> time to look at these :( - maybe someone else can take them up
>>> >
>>> > Hi Matthew!
>>> >
>>> > If you could please file these in a PR and CC me I will try and wor=
k
>>> > through all of these.
>>>
>>> Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D162754
>>
>> Thank you! I will try and clean all this up, but as I'm sure you're
>> aware we are coming up on a holiday in the states so my time is limite=
d
>> for the next few days. I will look at this as time permits though!
>>
>> -- WXS
>=20
> I did have a brief look at some of these and it was a great catch. One =
item
> I did find interesting is a number of these define LATEST_LINK, but it =
just
> matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped=

> -- on
> a case-by-case basis, of course.

Yes -- in fact, all the ports where PORT_DBDIR was redefined also set
OPTIONSFILE to what would be the default value in any case.  About half
the ports mentioned were essentially clones of one of the
phpX-extensions ports or borrowed heavily from them.

I did a bit of checking to see if there were any other common cases with
OPTIONSFILE but couldn't find anything obvious.   Haven't searched for
people setting LATEST_LINK to what would be the default in any case.

Hmmm... just by inspection, there's a lot of ports that essentially set
LATEST_LINK to ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} -- and that
is actually the default value already.  I'll stick looking into that on
the queue.

	Cheers,

	Matthew

--=20
Dr Matthew J Seaman MA, D.Phil.                   7 Priory Courtyard
                                                  Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey     Ramsgate
JID: matthew@infracaninophile.co.uk               Kent, CT11 9PW


--------------enig4558AC5DA2E1A8CB242E9F9C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7L+FUACgkQ8Mjk52CukIyjiwCeNVTAbHo4sNm4scYZNXsxTNes
36QAnjVvFNOcbdZ7bmt3XgMdgwh4otCi
=bRvf
-----END PGP SIGNATURE-----

--------------enig4558AC5DA2E1A8CB242E9F9C--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ECBF84C.4050209>