Date: Wed, 30 Nov 2011 17:59:33 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: Doug Barton <dougb@freebsd.org>, Warner Losh <imp@freebsd.org>, current@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: Remove debug echo Message-ID: <CAGH67wT18DLu%2BOhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q@mail.gmail.com> In-Reply-To: <20111201014349.GA61475@freebsd.org> References: <201111291607.26546.jhb@freebsd.org> <A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com> <20111201002515.GA50028@freebsd.org> <CAGH67wQFecLHFsANmWFSr6e%2B99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com> <20111201014349.GA61475@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best <arundel@freebsd.org> wrote=
:
> On Wed Nov 30 11, Garrett Cooper wrote:
>> On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best <arundel@freebsd.org> wr=
ote:
>> > On Tue Nov 29 11, Warner Losh wrote:
>> >> kill it.
>> >>
>> >> Warner
>> >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
>> >>
>> >> > Any objections to this? =A0It removes a weird line during 'make -s =
buildworld'
>> >> > output and I think it was debugging accidentally left in in 213077 =
by Warner:
>> >> >
>> >> > Index: newvers.sh
>> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> >> > --- newvers.sh =A0 =A0 =A0(revision 228074)
>> >> > +++ newvers.sh =A0 =A0 =A0(working copy)
>> >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
>> >> > done
>> >> >
>> >> > if [ -n "$svnversion" ] ; then
>> >> > - =A0 echo "$svnversion"
>> >> > =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion`
>> >> > =A0 =A0 case "$svn" in
>> >> > =A0 =A0 [0-9]*) svn=3D" r${svn}" ;;
>> >
>> > also...
>> >
>> > when running buildkernel via 'make -s', do we really need all those mo=
dule
>> > printfs? i see messages for "cleandir", "obj", "depend" and "all". i t=
hink for
>> > 'make -s', that's pure overkill!
>> >
>> > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times=
4 and
>> > you'll get 2680 lines of output. not really *silent*, is it? ;)
>>
>> =A0 =A0 pmake sucks as far as diagnostic output is concerned when compar=
ed
>> with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
>> and it's not a race) to determine what directory created the "Error
>> Code" output. With the printouts discussed here, at least you have a
>> chance at determining what the issue was.
>> =A0 =A0 Maybe it's just me, but I like noisy builds -- otherwise the
>> amount of time I have to spend root-causing the issue becomes
>> expensive.
>
> ehmmm...a noisy silent flag? i totally agree, if we're talking about 'mak=
e' in
> its default mode, but what's the point of a silent flag, if it produces >=
2500
> lines of output? nobody uses the -s flag for diagnostics. its purpose is =
to
> build a kernel without producing a lot of output and also not fiddling wi=
th
> stdout/stderr to achieve that goal.
What I really want is this:
$ cat Makefile
all: foo bar baz yadda
foo bar yadda:
baz:
false
$ gmake
false
gmake: *** [baz] Error 1
^^^^
$ make all
false
*** Error code 1
Stop in /tmp.
Otherwise diagnosing issues becomes a PITA with -j > 1 (with pmake I
have to start using some serious grep'ing, and if I'm lucky I can find
the source of error). If I get a few spare cycles I might just
implement it and post a patch somewhere (the entering and leaving
directory feature of gmake is really nice too, but it's less
important.. unless you have the same target in multiple directories)..
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wT18DLu%2BOhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q>