Date: Tue, 20 Dec 2011 21:37:55 +0900 (EIT) From: Gerald Pfeifer <gerald@pfeifer.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: Brendan Fabeny <bf1783@gmail.com>, Mark Linimon <linimon@lonesome.com>, freebsd-ports@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org> Subject: Re: [PATCH] lang/gcc -- Fix build on freebsd-current Message-ID: <alpine.LNX.2.00.1112202136320.27755@zbenl.fvgr> In-Reply-To: <20111219192504.GA32480@troutmask.apl.washington.edu> References: <CAGFTUwPYkDrR4Damj8QEfaa6D6mRnt%2B1NrLCnzisYC2ZpHRVVg@mail.gmail.com> <alpine.LNX.2.00.1112191605280.2707@zbenl.fvgr> <20111219192504.GA32480@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 19 Dec 2011, Steve Kargl wrote: > Not sure why you need confirmation before committing if it works for > you, because anything has to be better than the current state. Well, I prefer not having to follow up with further patches later (and luckily my full testing uncovered another small issue). > Why? Given that the typical build is 'make && make install && make clean', > patching ChangeLog seems rather odd. The same question applies to the > other ChangeLog diffs that I've removed. I was going for the full upstream changeset, consuming that directly. Based on your feedback I just noted the upstream revision ids and omitted the ChangeLog patches. Thanks, Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1112202136320.27755>