Date: Sun, 05 Feb 2012 01:21:50 +0000 From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: sem@FreeBSD.org, mark@mivok.net, net@FreeBSD.org Subject: Re: [CFT] multiple FIB support in route(8) Message-ID: <4F2DD9AE.7040805@FreeBSD.org> In-Reply-To: <20120205.060517.982494808613553569.hrs@allbsd.org> References: <20120205.033532.381149506660559829.hrs@allbsd.org> <4F2DC674.4070401@FreeBSD.org> <20120205.060517.982494808613553569.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04.02.2012 21:05, Hiroki Sato wrote: > "Alexander V. Chernikov"<melifaro@FreeBSD.org> wrote > in<4F2DC674.4070401@FreeBSD.org>: > > me> On 04.02.2012 18:35, Hiroki Sato wrote: > me> > Hello, > me> > > me> > Can anyone review/test the attached patch to add "-fib number" option > me> > to route(8)? This should simplify static route configuration across > me> > multiple FIBs in rc.conf. Just adding an -fib option like the > me> > following will do the trick without changing rc.d/routing: > me> > > me> > static_routes="foo bar" > me> > route_foo="10.1.1.1/24 192.168.2.1 -fib 2" > me> > route_bar="10.1.1.1/24 192.168.2.1 -fib 3" > me> > > me> > The -fib option is supported in all subcommands but monitor. > me> Why should we leave `monitor` as is? > me> > me> And, even if we really need to do so why "route monitor" silently > me> accepts and ignores -fib X key? > > No specific reason. The monitor originally supports no flag to > filter rt messages and silently ignores any flag. `setfib 5 route monitor` listening to fib 5 vs `route monitor -fib 5` listening to fib 0 is obviously not expected behavior :) > > Is this a suggestion that it should support -fib or just from your There is no reason to leave it inconsistent with other route subcommands. Route monitor is useful in various debugging related to dynamic routing software (and it should be fib-aware). > curiosity? I do not think we really need to leave it. The attached > patch is enough to support it, too. Thanks. Btw, I've tested patch from previous email on my 8-S box, it works correctly. > > -- Hiroki
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F2DD9AE.7040805>