Date: Mon, 12 Mar 2012 22:37:55 -0500 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Alexander Motin <mav@freebsd.org>, Nathan Whitehorn <nwhitehorn@freebsd.org>, "freebsd-usb@freebsd.org" <freebsd-usb@freebsd.org> Subject: Re: Ongoing battle with umass(4) and xhci(4) Message-ID: <CALBk6yLg7gt2ZkQPHQwTfA-NxCV9i6BHdjeiurk_6M4=3V9V8A@mail.gmail.com> In-Reply-To: <201203120915.18908.hselasky@c2i.net> References: <CALBk6y%2BoYS4CuXpt0Uwm_KsSPKyhtn2mCHaSk7O0meWoPB1ZzA@mail.gmail.com> <201203120915.18908.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 12, 2012 at 3:15 AM, Hans Petter Selasky <hselasky@c2i.net> wro=
te:
>>
>> Is there something fishy happening between the USB stack and CAM? hmmm..=
.
>>
>
> No,
>
> It is not the CAM layer this time, though there are some bugs there too.
>
>
> In the beginning of the log I see that in the successful case we receive =
a
> stall event:
>
> -xhci_check_transfer: slot=3D1 epno=3D3 remainder=3D13 status=3D6
> -xhci_check_transfer: TD is last
> -xhci_cmd_stop_ep:
> -xhci_check_command: Received command event
> -xhci_configure_reset_endpoint: Could not stop endpoint 3
> -xhci_cmd_reset_ep:
> -xhci_check_command: Received command event
> -xhci_cmd_set_tr_dequeue_ptr:
> -xhci_check_command: Received command event
> -xhci_cmd_evaluate_ctx:
> -xhci_check_command: Received command event
> -xhci_cmd_configure_ep:
> -xhci_check_command: Received command event
> -xhci_configure_reset_endpoint: Could not configure endpoint 3
> -xhci_ep_clear_stall:
> -xhci_device_generic_enter:
> -xhci_setup_generic_chain_sub: NTRB=3D1
> -xhci_setup_generic_chain_sub: LINK=3D0x82883180
> -xhci_setup_generic_chain_sub: NTRB=3D1
> -xhci_setup_generic_chain_sub: LINK=3D0x82883000
> -xhci_setup_generic_chain: first=3D0xffffff8460883300 last=3D0xffffff8460=
883180
> -xhci_device_generic_start:
> -xhci_transfer_insert: qh_pos =3D 1
> -xhci_check_transfer: slot=3D1 epno=3D1 remainder=3D0 status=3D1
> -xhci_check_transfer: slot=3D1 epno=3D1 remainder=3D0 status=3D1
> -xhci_check_transfer: Following next TD
> -xhci_check_transfer: slot=3D1 epno=3D1 remainder=3D0 status=3D1
> -xhci_check_transfer: slot=3D1 epno=3D1 remainder=3D0 status=3D1
> -xhci_check_transfer: TD is last
>
>
> This is not received in the failing case.
>
> Maybe this indicates a lost interrupt or something like that?
>
> In /sys/dev/usb/controller/xhci.c
>
> static void
> xhci_interrupt_poll(struct xhci_softc *sc)
>
> Add a printf:
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (i =3D=3D XHCI_MAX_EVENTS) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0i =3D 0;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0j ^=3D 1;
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* check for timeout */
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (!--t) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+ =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printf("XHCI: Timeout\n");
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
>
>
> See if what happens.
>
> Also change the xhci.c code to call
>
> xhci_interrupt_poll() two times instead of one.
>
>
> --HPS
Unfortunately, the condition was never reached.
I've started trying to dtrace xhci(4) function boundaries, and, well
there's a lot of recursion with xhci_interrupt_poll(). However, I
never see that function called from xhci_do_poll(), which is called
from xhci_interrupt() (to "catch any lost interrupts" according to the
comment).
You may have already told me this, but what does "Down reving Protocol
Version from 2 to 0?" in the success case on my system? Is this the
USB protocol which is "down rev'ed"? If so, what USB level is this
flash drive running at?
-Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALBk6yLg7gt2ZkQPHQwTfA-NxCV9i6BHdjeiurk_6M4=3V9V8A>