Date: Sun, 10 Jun 2012 09:45:53 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: "Cherry G. Mathew" <cherry@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236813 - projects/amd64_xen_pv/sys/amd64/include Message-ID: <20120610094048.Y1188@besplex.bde.org> In-Reply-To: <201206091258.q59Cw0Kb033870@svn.freebsd.org> References: <201206091258.q59Cw0Kb033870@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 9 Jun 2012, Cherry G. Mathew wrote: > Log: > Xen's "pseudo-physical" "ram" space is a fragmented by virtue of its bootstrap > sequence. vm requires this #define to stitching up the pieces into the > kva while booting up. See: vm_page.c:vm_page_startup() > > Approved by: gibbs (implicit) > > Modified: > projects/amd64_xen_pv/sys/amd64/include/vmparam.h > > Modified: projects/amd64_xen_pv/sys/amd64/include/vmparam.h > ============================================================================== > --- projects/amd64_xen_pv/sys/amd64/include/vmparam.h Sat Jun 9 12:27:30 2012 (r236812) > +++ projects/amd64_xen_pv/sys/amd64/include/vmparam.h Sat Jun 9 12:58:00 2012 (r236813) > @@ -79,7 +79,11 @@ > /* > * The physical address space is densely populated. > */ > +#ifndef XEN > #define VM_PHYSSEG_DENSE > +#else /* XEN */ > +#define VM_PHYSSEG_SPARSE > +#endif See style(9). The style bugs here are: - comment on #else for a short #ifdef - #ifndef instead of #ifdef when there is an #else - comment no longer matches code (or the log message). It applies to the whole ifdef, but the ifdef is manifestly for handling address spaces that are _not_ densely populated. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120610094048.Y1188>