Date: Tue, 23 Oct 2012 14:31:02 +0200 From: Jaap Akkerhuis <jaap@NLnetLabs.nl> To: Erwin Lansing <erwin@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/172903: dns/opendnssec convert to OPTIONSNG Message-ID: <201210231231.q9NCV2ab074056@bela.nlnetlabs.nl> In-Reply-To: <20121023095255.GM4474@droso.net> References: <201210211803.q9LI3aCV044793@freefall.freebsd.org> <20121023095255.GM4474@droso.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hoi Erwin,
If I'm diffing the diffs correctly, you used the first version of
my patch to send the new one and the main change you made was to
move the ruby check back to the bottem after the inclusion of
bsd.port.post.mk.
Yes.
My second patch, attached for completeness, actually did the same,
I didn't realise the differences between the two and I used the first
because I could download that one. It also worked. (The second didn't.
Not being ean attachment, it got butchered somewhere.)
but also moved the OPTIONS_* macros before including
bsd.port.options.mk, which is the recommended way. Is this patch
fine with you, or did I overlook anything?
This is fine with me, no problem. (And, for good measures, I tested it
on my test tinderboxes).
Thanks!
jaap
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210231231.q9NCV2ab074056>