Date: Sun, 24 Feb 2013 16:57:13 -0600 From: Jeremy Messenger <mezz.freebsd@gmail.com> To: Alexey Dokuchaev <danfe@nsu.ru> Cc: gnome@freebsd.org Subject: Re: [patch] devel/libgsf: make GCONF really OPTIONal Message-ID: <CADLFttfqGf9g=4-fUSH9myg4oZgLEY-Lynh9YqPG5J_OWTdchg@mail.gmail.com> In-Reply-To: <20130223042009.GA99230@regency.nsu.ru> References: <20130222163516.GA51990@regency.nsu.ru> <CADLFttcHuHnSmi1FEbwqkAST84JgAehFDbFJFfrN4bnMQNfuYA@mail.gmail.com> <20130223042009.GA99230@regency.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 22, 2013 at 10:20 PM, Alexey Dokuchaev <danfe@nsu.ru> wrote: > On Fri, Feb 22, 2013 at 12:46:53PM -0600, Jeremy Messenger wrote: >> On Fri, Feb 22, 2013 at 10:35 AM, Alexey Dokuchaev <danfe@nsu.ru> wrote: >> > hi there, >> > >> > it's a bit inconvenient to manually specify WITHOUT_GCONF every time i >> > build devel/libgsf. mind if i commit attached patch? >> >> We can't use OPTIONS with the auto check dependency. It breaks the >> user usability, IMO. I can't access to the FreeBSD for a few weeks, >> so can you check to see if there is flag in its configure to disable >> gconf? If it does then remove that auto check and add the disable flag >> then you can commit it. Thanks! > > Yes, there is a --without-gconf switch, and it works as advertised. I've > also removed PLIST_SUB magic, as it seems a bit excessive for just one > file, and used PLIST_FILES instead. New diff is attached. I am no fan of PLIST_FILES and plist dynamic because both cripple my search for file in pkg-plist. But I don't really care at some point, so you can go ahead commit it. Thanks! > ./danfe -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttfqGf9g=4-fUSH9myg4oZgLEY-Lynh9YqPG5J_OWTdchg>